[GitHub] [kafka] dielhennr commented on a change in pull request #11159: MINOR: Change default node id in kraft broker properties

[GitBox]

dielhennr commented on a change in pull request #11159:
URL: https://github.com/apache/kafka/pull/11159#discussion_r681202052



##########
File path: 
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java
##########
@@ -239,11 +239,11 @@ public void replay(RegisterBrokerRecord record) {
             features.put(feature.name(), new VersionRange(
                 feature.minSupportedVersion(), feature.maxSupportedVersion()));
         }
+        BrokerRegistration prevRegistration = 
brokerRegistrations.getOrDefault(brokerId, null);

Review comment:
       This was still a bug then correct? `prevRegistration` was being assigned 
to `Map::get` not `Map::put`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org