Justinwins commented on a change in pull request #10652:
URL: https://github.com/apache/kafka/pull/10652#discussion_r683330997
##########
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##########
@@ -175,6 +175,7 @@ public MirrorClientConfig clientConfig(String cluster) {
props.putAll(stringsWithPrefix("header.converter"));
props.putAll(stringsWithPrefix("task"));
props.putAll(stringsWithPrefix("worker"));
+ props.putAll(stringsWithPrefix("replication.policy"));
Review comment:
In MirrorClientConfig ,it seems that it's not necessary to add
replication.policy into the props.
As i see ,
org.apache.kafka.connect.mirror.MirrorClientConfig#replicationPolicy
initialise the ReplicationPolicy instance,
and in MirrorClient this instance is used ,where ReplicationPolicy takes
effect for real.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
