[ 
https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399306#comment-17399306
 ] 

Christo Lolov commented on KAFKA-12994:
---------------------------------------

Hey [~ableegoldman], what would the best approach to contributing these changes 
be if two people are working on them? Andrew and I continue to work on the same 
branch and open only one PR? We split the unit test files (two each) and each 
one of us opens a separate PR? In order to get traction should we add you as a 
reviewer to the PR(s) and/or [~iekpo] or is there a (mailing-)list where we can 
ask for assistance?

> Migrate all Tests to New API and Remove Suppression for Deprecation Warnings 
> related to KIP-633
> -----------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-12994
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12994
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, unit tests
>    Affects Versions: 3.0.0
>            Reporter: Israel Ekpo
>            Assignee: Andrew patterson
>            Priority: Major
>              Labels: kip-633, newbie, newbie++
>             Fix For: 3.1.0
>
>
> Due to the API changes for KIP-633 a lot of deprecation warnings have been 
> generated in tests that are using the old deprecated APIs. There are a lot of 
> tests using the deprecated methods. We should absolutely migrate them all to 
> the new APIs and then get rid of all the applicable annotations for 
> suppressing the deprecation warnings.
> The applies to all Java and Scala examples and tests using the deprecated 
> APIs in the JoinWindows, SessionWindows, TimeWindows and SlidingWindows 
> classes.
>  
> This is based on the feedback from reviewers in this PR
>  
> https://github.com/apache/kafka/pull/10926



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to