lbradstreet commented on a change in pull request #11230:
URL: https://github.com/apache/kafka/pull/11230#discussion_r691487441
##########
File path: core/src/main/scala/kafka/server/ConfigHandler.scala
##########
@@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
- val logConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
- logs.foreach(_.updateConfig(logConfig))
+ val newLogConfig =
LogConfig.fromProps(logManager.currentDefaultConfig.originals, props)
Review comment:
That does seem better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
