[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

[GitBox]

dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692175152



##########
File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala
##########
@@ -82,7 +82,7 @@ class AbstractFetcherThreadTest {
 
     // add one partition to create the consumer lag metric
     fetcher.setReplicaState(partition, 
MockFetcherThread.PartitionState(leaderEpoch = 0))
-    fetcher.addPartitions(Map(partition -> initialFetchState(0L, leaderEpoch = 
0)))
+    fetcher.addPartitions(Map(partition -> 
initialFetchState(Some(topicIds.get(partition.topic())),0L, leaderEpoch = 0)))

Review comment:
       nit: If we keep `topicIds` as a Scala map, we would get an Option 
directly with `topicIds.get(...)`. Also, a space is missing after the `,` and 
the `()` could be omitted ;).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org