rondagostino commented on a change in pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#discussion_r692561636
##########
File path: core/src/main/scala/kafka/server/KafkaBroker.scala
##########
@@ -85,7 +85,8 @@ trait KafkaBroker extends KafkaMetricsGroup {
explicitMetricName(Server.MetricsPrefix, KafkaBroker.MetricsTypeName,
name, metricTags)
}
- newGauge("BrokerState", () => brokerState.value)
+ // visible for testing
+ private[server] val brokerStateGauge = newGauge("BrokerState", () =>
brokerState.value)
Review comment:
Agreed, we don't need it;
`ServerStartupTest.testBrokerStateRunningAfterZK()` goes directly against the
brokerState method. Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
