showuon commented on a change in pull request #11244:
URL: https://github.com/apache/kafka/pull/11244#discussion_r693291090
##########
File path:
core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
##########
@@ -127,7 +127,6 @@ class ReassignPartitionsIntegrationTest extends
ZooKeeperTestHarness {
)
val verifyAssignmentResult = runVerifyAssignment(cluster.adminClient,
assignment, false)
- assertTrue(verifyAssignmentResult.partsOngoing)
assertFalse(verifyAssignmentResult.movesOngoing)
Review comment:
I checked and confirmed that this change makes sense, because there
might not have on-going reassignment at this moment if the reassignment
completed before we verify it.
However, in this case, I don't think we verify the `moveOngoing` makes sense
here, either, since it might passed just because the reassignment completed
before the verification. I think we can directly remove all these 3 lines and
directly wait for the reassignment completion. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
