guozhangwang commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r697736171
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ########## @@ -269,6 +300,12 @@ public final void removeAllThreadLevelSensors(final String threadId) { metrics.removeSensor(sensors.pop()); } } + synchronized (threadLevelMetrics) { Review comment: Ah right, the start time / total blocked time are registered as metrics directly. In that case could you separate them and put this as in `removeAllThreadLevelMetrics` just like the client-level registration/removal above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org