mumrah commented on a change in pull request #11312:
URL: https://github.com/apache/kafka/pull/11312#discussion_r706419226
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1385,10 +1385,22 @@ object KafkaConfig {
}
if (maybeSensitive) Password.HIDDEN else value
}
+
+ def populateSynonyms(input: util.Map[_, _]): util.Map[Any, Any] = {
+ val output = new util.HashMap[Any, Any](input)
Review comment:
Is it safe to make a new map here? Are there any callers of
KafkaConfig() which might expect to modify the props map after the object has
been constructed?
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1385,10 +1385,22 @@ object KafkaConfig {
}
if (maybeSensitive) Password.HIDDEN else value
}
+
+ def populateSynonyms(input: util.Map[_, _]): util.Map[Any, Any] = {
Review comment:
A comment or docstring would be useful here explaining the motivation
for this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
