junrao commented on a change in pull request #11348:
URL: https://github.com/apache/kafka/pull/11348#discussion_r713413729
##########
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##########
@@ -118,7 +118,7 @@ class ZkAdminManager(val config: KafkaConfig,
metadataAndConfigs.get(topicName).foreach { result =>
val logConfig =
LogConfig.fromProps(LogConfig.extractLogConfigMap(config), configs)
val createEntry = configHelper.createTopicConfigEntry(logConfig,
configs, includeSynonyms = false, includeDocumentation = false)(_, _)
- val topicConfigs = logConfig.nonInternalValues.asScala.map { case (k, v)
=>
+ val topicConfigs = (logConfig.originals.asScala.filter(_._2 != null) ++
logConfig.nonInternalValues.asScala).map { case (k, v) =>
Review comment:
Could we move ConfigHelper.describeConfigs.allConfigs to ConfigHelper
and reuse it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
