ccding commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-933622186


   While I am working on the test, I have a question:
   
   The `log.flush()` function is also called at 
https://github.com/apache/kafka/blob/db42afd6e24ef4291390b4d1c1f10758beedefed/core/src/main/scala/kafka/log/LogManager.scala#L1245
 and 
https://github.com/apache/kafka/blob/db42afd6e24ef4291390b4d1c1f10758beedefed/core/src/main/scala/kafka/log/UnifiedLog.scala#L933
   
   They are not during a shutdown. Will these also flush empty active segments 
and hurt performance?
   
   cc @junrao @kowshik 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to