jsancio opened a new pull request #11386:
URL: https://github.com/apache/kafka/pull/11386


   There are a few fixes included in this commit.
   1. When loading a snapshot the broker `BrokerMetadataListener` was using the 
batch's append time, offset and epoch. These are not the same as the append 
time, offset and epoch from the log. We must instead use the 
`lastContainedLogTimeStamp`, `lastContainedLogOffset` and 
`lastContainedLogEpoch` from the `SnapshotReader`.
   2. Include the highest offset and epoch into the `MetadataImage` and 
`MetadataDelta`. Adding the offset and epoch to `MetadataImage` is useful to 
version the image and to simplify the API. Adding the offset and epoch to 
`MetadataDelta` is needed to generate the `MetadataImage`.
   3. Swapped the order of the arguments for `ReplicaManager.applyDelta` for 
consistency to match the order of the arguments for `MetadataPublisher.publish`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to