showuon commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r730765761
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/DescribeUserScramCredentialsRequest.java
##########
@@ -66,8 +66,15 @@ public DescribeUserScramCredentialsRequestData data() {
@Override
public AbstractResponse getErrorResponse(int throttleTimeMs, Throwable e) {
ApiError apiError = ApiError.fromThrowable(e);
- return new DescribeUserScramCredentialsResponse(new
DescribeUserScramCredentialsResponseData()
+ DescribeUserScramCredentialsResponseData response = new
DescribeUserScramCredentialsResponseData()
+ .setThrottleTimeMs(throttleTimeMs)
.setErrorCode(apiError.error().code())
- .setErrorMessage(apiError.message()));
+ .setErrorMessage(apiError.message());
+ for (DescribeUserScramCredentialsRequestData.UserName user :
data.users()) {
+ response.results().add(new
DescribeUserScramCredentialsResponseData.DescribeUserScramCredentialsResult()
+ .setErrorCode(apiError.error().code())
+ .setErrorMessage(apiError.message()));
Review comment:
I think this was a bug, right? Should we file a bug and handle it
separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
