cmccabe commented on a change in pull request #10772:
URL: https://github.com/apache/kafka/pull/10772#discussion_r732038559
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumControllerMetrics.java
##########
@@ -26,28 +26,36 @@
import java.util.Objects;
public final class QuorumControllerMetrics implements ControllerMetrics {
- private final static MetricName ACTIVE_CONTROLLER_COUNT = getMetricName(
- "KafkaController", "ActiveControllerCount");
- private final static MetricName EVENT_QUEUE_TIME_MS = getMetricName(
- "ControllerEventManager", "EventQueueTimeMs");
- private final static MetricName EVENT_QUEUE_PROCESSING_TIME_MS =
getMetricName(
- "ControllerEventManager", "EventQueueProcessingTimeMs");
- private final static MetricName GLOBAL_TOPIC_COUNT = getMetricName(
- "KafkaController", "GlobalTopicCount");
- private final static MetricName GLOBAL_PARTITION_COUNT = getMetricName(
- "KafkaController", "GlobalPartitionCount");
- private final static MetricName OFFLINE_PARTITION_COUNT = getMetricName(
- "KafkaController", "OfflinePartitionsCount");
- private final static MetricName PREFERRED_REPLICA_IMBALANCE_COUNT =
getMetricName(
- "KafkaController", "PreferredReplicaImbalanceCount");
-
+ private final static MetricName ACTIVE_CONTROLLER_COUNT = new MetricName(
Review comment:
why are we changing from `getMetricName` to `new MetricName`? Should
this be a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
