kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733259046
########## File path: clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenValidatorFactoryTest.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.common.security.oauthbearer.secured; + +import java.io.IOException; +import java.util.Map; +import org.apache.kafka.common.KafkaException; +import org.junit.jupiter.api.Test; + +public class AccessTokenValidatorFactoryTest extends OAuthBearerTest { + + @Test + public void testConfigureThrowsExceptionOnAccessTokenValidatorInit() { + OAuthBearerLoginCallbackHandler handler = new OAuthBearerLoginCallbackHandler(); + AccessTokenRetriever accessTokenRetriever = new AccessTokenRetriever() { + @Override + public void init() throws IOException { + throw new IOException("My init had an error!"); + } + @Override + public String retrieve() { + return "dummy"; + } + }; + + Map<String, ?> configs = getSaslConfigs(); + AccessTokenValidator accessTokenValidator = AccessTokenValidatorFactory.create(configs); + + assertThrowsWithMessage( + KafkaException.class, () -> handler.configure(accessTokenRetriever, accessTokenValidator), "encountered an error when initializing"); + } + + @Test + public void testConfigureThrowsExceptionOnAccessTokenValidatorClose() { + OAuthBearerLoginCallbackHandler handler = new OAuthBearerLoginCallbackHandler(); + AccessTokenRetriever accessTokenRetriever = new AccessTokenRetriever() { + @Override + public void close() throws IOException { + throw new IOException("My close had an error!"); + } + @Override + public String retrieve() { + return "dummy"; + } + }; + + Map<String, ?> configs = getSaslConfigs(); + AccessTokenValidator accessTokenValidator = AccessTokenValidatorFactory.create(configs); + handler.configure(accessTokenRetriever, accessTokenValidator); + + // Basically asserting this doesn't throw an exception :( Review comment: The `AuthenticateCallbackHandler` interface's `close` method doesn't allow for exceptions. So in our implementation, we just catch any errors and log them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
