showuon commented on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948316660
> And if the asynchronous submission fails all the time, we need to consider how to control a timeout period during multiple calls to consumer.poll. I don't think that would happen. If so, there might be some issues on the brokers. > I think it’s a weird practice to maintain a timeout for asynchronous operations. At the same time, its effect is actually equivalent to only do commitOffset once, setting a timeout MIN (poll timer, the configured timer) for this commit, and letting customers to consider how to better adjust these parameters poll timer, the configured timer. No, the `commitAsync` timeout meaning here is different from the `commitSync`. The `commitSync` with `MIN (poll timer, the configured timer)` will keep retrying if retriable errors, on the other hand, the timeout in `commitAsync`, is the timeout we wait for the response from the broker (and just once). I think @guozhangwang and @hachikuji 's async commit proposal can completely fix the issue you described. And of course, your proposal to have 2 more configs to allow users to adjust sync/async and timeout value is more flexible. In my opinion, I'd prefer to fix in a simpler way, to always have async commit in `onJoinPrepare`. That's my 2 cents. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
