[GitHub] [kafka] showuon commented on a change in pull request #11413: KAFKA-13370: add errors when commit offsets failed and add tests

[GitBox]

showuon commented on a change in pull request #11413:
URL: https://github.com/apache/kafka/pull/11413#discussion_r731649801



##########
File path: 
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java
##########
@@ -1580,9 +1652,22 @@ private void assertPollMetrics(int 
minimumPollCountExpected) {
         assertTrue(Double.isNaN(pollBatchTimeAvg) || pollBatchTimeAvg > 0.0d);
         double activeCount = 
metrics.currentMetricValueAsDouble(sourceTaskGroup, 
"source-record-active-count");
         double activeCountMax = 
metrics.currentMetricValueAsDouble(sourceTaskGroup, 
"source-record-active-count-max");
-        assertEquals(0, activeCount, 0.000001d);
-        if (minimumPollCountExpected > 0) {
-            assertEquals(RECORDS.size(), activeCountMax, 0.000001d);
+
+        if (isWriteCompleted) {
+            assertEquals(0, activeCount, 0.000001d);
+            if (minimumPollCountExpected > 0) {
+                assertEquals(RECORDS.size(), activeCountMax, 0.000001d);
+            }
+        }
+
+        double failurePercentage = 
metrics.currentMetricValueAsDouble(taskGroup, 
"offset-commit-failure-percentage");
+        double successPercentage = 
metrics.currentMetricValueAsDouble(taskGroup, 
"offset-commit-success-percentage");
+
+        if (!isCommitSucceeded) {
+            assertTrue(failurePercentage > 0);
+        } else {
+            assertTrue(failurePercentage == 0);
+            assertTrue(successPercentage > 0);

Review comment:
       Add `offset-commit-failure-percentage` and 
`"offset-commit-success-percentage` metrics verification.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org