[GitHub] [kafka] dongjinleekr commented on a change in pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

[GitBox]

dongjinleekr commented on a change in pull request #11429:
URL: https://github.com/apache/kafka/pull/11429#discussion_r735114228



##########
File path: core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala
##########
@@ -123,6 +123,25 @@ class TopicCommandTest {
           "--topic", topicName)))
   }
 
+  @Test
+  def testCreateWithoutPartitionCountAndReplicationFactorShouldSucceed(): Unit 
= {
+    val opts = new TopicCommandOptions(
+      Array("--bootstrap-server", brokerList,
+        "--create",
+        "--topic", topicName))
+    opts.checkArgs()
+  }
+
+  @Test
+  def testDescribeShouldSucceed(): Unit = {
+    val opts = new TopicCommandOptions(
+      Array("--bootstrap-server", brokerList,
+        "--describe",
+        "--topic", topicName))
+    opts.checkArgs()
+  }

Review comment:
       I love this case-by-case approach + it also works like a charm. :smiley:
   
![20211024-214641](https://user-images.githubusercontent.com/2375128/138594843-52779e07-31ea-4f85-af5b-c25b56025b77.png)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org