mimaison commented on a change in pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#discussion_r739322252



##########
File path: 
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java
##########
@@ -152,6 +152,44 @@ public void testConfigPropertyFiltering() {
             .anyMatch(x -> x.name().equals("min.insync.replicas")), "should 
not replicate excluded properties");
     }
 
+    @Test
+    public void testConfigPropertyFilteringExclude() {

Review comment:
       Even without the code change, this test is passing. It's because it's 
calling `connector.targetConfig()` while the fix is in `createNewTopics()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to