mjsax commented on a change in pull request #11368: URL: https://github.com/apache/kafka/pull/11368#discussion_r729526952
########## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TableJoined.java ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.kstream; + +import org.apache.kafka.streams.processor.StreamPartitioner; + +import java.util.function.Function; + +/** + * The {@code TableJoined} class represents optional params that can be passed to + * {@link KTable#join(KTable, Function, ValueJoiner, TableJoined) KTable#join(KTable,Function,...)} and + * {@link KTable#leftJoin(KTable, Function, ValueJoiner, TableJoined) KTable#leftJoin(KTable,Function,...)} + * operations, for foreign key joins. + * @param <K> this key type ; key type for the left (primary) table + * @param <KO> other key type ; key type for the right (foreign key) table + */ +public class TableJoined<K, KO> implements NamedOperation<TableJoined<K, KO>> { + + protected final StreamPartitioner<K, Void> partitioner; + protected final StreamPartitioner<KO, Void> otherPartitioner; + protected final String name; + + private TableJoined(final StreamPartitioner<K, Void> partitioner, + final StreamPartitioner<KO, Void> otherPartitioner, + final String name) { + this.partitioner = partitioner; + this.otherPartitioner = otherPartitioner; + this.name = name; + } + + protected TableJoined(final TableJoined<K, KO> tableJoined) { + this(tableJoined.partitioner, tableJoined.otherPartitioner, tableJoined.name); + } + + /** + * Create an instance of {@code TableJoined} with partitioner and otherPartitioner {@link StreamPartitioner} instances. Review comment: It's also worth to point out, that specifying a partitioner does _not_ repartition the input data. It's purpose is solely to _tell/inform_ the runtime how the input data is in fact partitioned (to compute the join result correctly). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org