showuon edited a comment on pull request #11451: URL: https://github.com/apache/kafka/pull/11451#issuecomment-959028970
@guozhangwang , that's a good point. Yes, I was focusing on the fix 1) above only. For 2), yes, we should also fix that, but I need some time to think a good way to fix that issue. And then open a jira ticket for it. However, for 1) only, we can fix the issue in `cooperativeStickeyAssignor`, because in cooperative sticky assignor, we only encode generation info in `Assignor#userData`. That means, when we clean up the `ownedPartition` in `subscriptions` in coordinator layer, even the `generation` in `Assignor#userData` is up-to-date, it won't affect the assignor do the assignment. The consumer lead will get the empty `ownedPartition` with correct generation ID from that consumer, which is fine to us. I'll continue to add tests for this PR. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
