bdesert commented on a change in pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#discussion_r742290825
##########
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
##########
@@ -519,6 +521,47 @@ public void testOffsetSyncsTopicsOnTarget() throws
Exception {
assertFalse(primaryTopics.contains("mm2-offset-syncs." +
BACKUP_CLUSTER_ALIAS + ".internal"));
}
+ @Test
Review comment:
I think I've had to check Mockito usage before.
This makes sense, really appreciate the help. Except for last line. Not sure
why we have to add hard dependency on `targetConfig` invocation, if assertions
in `doAnswer` provide full test coverage. I'll submit without the `verify`, let
me know if disagree, then I'll add `verify` line.
Also adding a change to the connector class itself, as it needs a visibility
change for this test. And still gonna keep integration test to follow the
existing approach.
Fully retested with `./gradlew connect:mirror:test`
##########
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
##########
@@ -519,6 +521,47 @@ public void testOffsetSyncsTopicsOnTarget() throws
Exception {
assertFalse(primaryTopics.contains("mm2-offset-syncs." +
BACKUP_CLUSTER_ALIAS + ".internal"));
}
+ @Test
Review comment:
I think I've had to check Mockito usage before.
This makes sense, really appreciate the help. Except for last line. Not sure
why we have to add hard dependency on `targetConfig` invocation, if assertions
in `doAnswer` provide full test coverage. I'll submit without the `verify`, let
me know if disagree, then I'll add `verify` line.
Also adding a change to the connector class itself, as it needs a visibility
change for this test. And still gonna keep integration test to follow the
existing approach.
Fully retested with `./gradlew connect:mirror:test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
