vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-960452877
> > While InMemoryWindowStore does enable strict retention but when combined with the caching store, it breaks. That's where doing it on MeteredStore might be beneficial. > > I see that, and personally I think this is a bug in the caching layer that we should be fixing --- in fact, the cache itself should better be trimmed by retention so that we can improve on our cache hit as well. I think it is fine to not piggy-back that fix in this PR if the scope suddenly become much larger, as I feel that the issue @mjsax raised worth being fixed by its own PR. I see.. So what you are suggesting is is that as part of this PR, I move all logic of strict enforcement to the innermost layer and fix the caching issue at the caching layer making the Metered layer cleaner. I think it makes sense because I feel, this PR has introduced some complexity which can be taken away. I can start with that unless @mjsax or @ableegoldman have a different opinion? Also, I looked at the ChangeLoggingXXXStores and in those implementations, it seems to be delegating to the underneath wrapped() store so I think we might be good there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
