dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r744877634
##########
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##########
@@ -413,8 +413,20 @@ abstract class AbstractFetcherThread(name: String,
case Errors.UNKNOWN_TOPIC_OR_PARTITION =>
warn(s"Received ${Errors.UNKNOWN_TOPIC_OR_PARTITION} from
the leader for partition $topicPartition. " +
- "This error may be returned transiently when the
partition is being created or deleted, but it is not " +
- "expected to persist.")
+ "This error may be returned transiently when the partition
is being created or deleted, but it is not " +
+ "expected to persist.")
+ partitionsWithError += topicPartition
+
+ case Errors.UNKNOWN_TOPIC_ID =>
+ warn(s"Received ${Errors.UNKNOWN_TOPIC_ID} from the leader
for partition $topicPartition. " +
+ "This error may be returned transiently when the partition
is being created or deleted, but it is not " +
+ "expected to persist.")
+ partitionsWithError += topicPartition
+
+ case Errors.INCONSISTENT_TOPIC_ID =>
+ warn(s"Received ${Errors.INCONSISTENT_TOPIC_ID} from the
leader for partition $topicPartition. " +
+ "This error may be returned transiently when the partition
is being created or deleted, but it is not " +
+ "expected to persist.")
Review comment:
Yeah, that should work. Otherwise, we could also make the method package
private and add a few unit tests for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
