rajinisivaram commented on a change in pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#discussion_r745400319
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -114,7 +114,9 @@ class KafkaServer(
var controlPlaneRequestHandlerPool: KafkaRequestHandlerPool = null
var logDirFailureChannel: LogDirFailureChannel = null
- var logManager: LogManager = null
+ var _logManager: LogManager = null
Review comment:
Do we want to make this private?
##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -204,16 +204,19 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
private val reconfigurables = mutable.Buffer[Reconfigurable]()
private val brokerReconfigurables = mutable.Buffer[BrokerReconfigurable]()
private val lock = new ReentrantReadWriteLock
- private var currentConfig = kafkaConfig
+ private var currentConfig: KafkaConfig = null
private val dynamicConfigPasswordEncoder =
maybeCreatePasswordEncoder(kafkaConfig.passwordEncoderSecret)
- private[server] def initialize(zkClient: KafkaZkClient): Unit = {
+ private[server] def initialize(zkClientOpt: Option[KafkaZkClient]): Unit = {
Review comment:
In the non-ZK world, does the initialization using existing dynamic
configs happen later? Or does the original Kafka config contain the existing
dynamic configs as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
