soceanainn opened a new pull request #11482:
URL: https://github.com/apache/kafka/pull/11482


   Originally, Callback would return a null metadata value when an error 
occurred.
   
   This was partially changed by 
[KAFKA-3303](https://issues.apache.org/jira/browse/KAFKA-3303), where in some 
cases Callback would return an 'empty' metadata. In this empty metadata 
TopicPartition is set correctly but all other fields are set as `-1`.
   
   The docs were later updated by 
[KAFKA-7412](https://issues.apache.org/jira/browse/KAFKA-7412), but it 
incorrectly states that Callback will always return this 'empty' metadata when 
an error occurs. However in the case of any exceptions that are a subclass of 
ApiException, Callback will still return a null value (see 
[here](https://github.com/apache/kafka/blob/3.1/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L1002)).
   
   This change fixes the behaviour when an ApiException is thrown, to align 
that behaviour with other exceptions and with the currently documented 
behaviour.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to