jolshan commented on a change in pull request #11004: URL: https://github.com/apache/kafka/pull/11004#discussion_r749683412
########## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ########## @@ -1206,7 +1205,8 @@ private void validatePositionsOnMetadataChange() { fetchable.put(node, builder); } - builder.add(partition, topicIds.getOrDefault(partition.topic(), Uuid.ZERO_UUID), new FetchRequest.PartitionData(position.offset, + Uuid topicId = metadata.topicId(partition.topic()); Review comment: It would have been a problem before KAFKA-13111 when we assumed only one topic ID per build for a given topic name (we had a mapping), but maybe it is ok now that we store the ID in the data and use it to build the request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org