functioner commented on a change in pull request #11504:
URL: https://github.com/apache/kafka/pull/11504#discussion_r750497406



##########
File path: core/src/main/scala/kafka/network/SocketServer.scala
##########
@@ -734,6 +734,10 @@ private[kafka] class Acceptor(val endPoint: EndPoint,
         val endThrottleTimeMs = e.startThrottleTimeMs + e.throttleTimeMs
         throttledSockets += DelayedCloseSocket(socketChannel, 
endThrottleTimeMs)
         None
+      case e: IOException =>
+        info(s"Encounter IOException", e)
+        closeSocket(socketChannel)

Review comment:
       @dajac You're right. I've updated the JIRA issue descriptions. I have a 
new commit using `close(endPoint.listenerName, socketChannel)`.
   For the test, since it involves injecting an IOException, I'm going to use 
Byteman or AspectJ. Or do you have any suggestion?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to