dajac commented on a change in pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#discussion_r752117851
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -746,8 +748,8 @@ public void handle(SyncGroupResponse syncResponse,
sensors.syncSensor.record(response.requestLatencyMs());
synchronized (AbstractCoordinator.this) {
- if (!generation.equals(Generation.NO_GENERATION) &&
state == MemberState.COMPLETING_REBALANCE) {
- // check protocol name only if the generation is
not reset
+ if (generation.protocolName != null && state ==
MemberState.COMPLETING_REBALANCE) {
+ // check protocol name only if the generation is
not reset (protocol name is not null)
Review comment:
I think that the intend was to validate `protocolName` only when the
generation was not reset. It seems that we are changing this here. Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
