rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r754608137
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1992,18 +1993,6 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
throw new ConfigException(s"Missing configuration
`${KafkaConfig.NodeIdProp}` which is required " +
s"when `process.roles` is defined (i.e. when running in KRaft
mode).")
}
-
- // Validate process.roles with controller.quorum.voters
- val voterIds: Set[Integer] =
RaftConfig.parseVoterConnections(quorumVoters).asScala.keySet.toSet
- if (voterIds.isEmpty) {
- throw new ConfigException(s"If using ${KafkaConfig.ProcessRolesProp},
${KafkaConfig.QuorumVotersProp} must contain a parseable set of voters.")
- } else if (processRoles.contains(ControllerRole)) {
- // Ensure that controllers use their node.id as a voter in
controller.quorum.voters
- require(voterIds.contains(nodeId), s"If
${KafkaConfig.ProcessRolesProp} contains the 'controller' role, the node id
$nodeId must be included in the set of voters
${KafkaConfig.QuorumVotersProp}=$voterIds")
- } else {
- // Ensure that the broker's node.id is not an id in
controller.quorum.voters
- require(!voterIds.contains(nodeId), s"If
${KafkaConfig.ProcessRolesProp} does not contain the 'controller' role, the
node id $nodeId must not be included in the set of voters
${KafkaConfig.QuorumVotersProp}=$voterIds")
- }
Review comment:
These checks are now handled below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
