dajac commented on a change in pull request #11530:
URL: https://github.com/apache/kafka/pull/11530#discussion_r755784474
##########
File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java
##########
@@ -113,10 +113,8 @@ private void finalizeSnapshotWithFooter() {
* Create an instance of this class and initialize
* the underlying snapshot with {@link SnapshotHeaderRecord}
*
- * @param snapshot a lambda to create the low level snapshot writer
Review comment:
Should this be `supplier` instead of `snapshot`?
##########
File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java
##########
@@ -113,10 +113,8 @@ private void finalizeSnapshotWithFooter() {
* Create an instance of this class and initialize
* the underlying snapshot with {@link SnapshotHeaderRecord}
*
- * @param snapshot a lambda to create the low level snapshot writer
* @param maxBatchSize the maximum size in byte for a batch
* @param memoryPool the memory pool for buffer allocation
- * @param time the clock implementation
Review comment:
Should this be `snapshotTime` instead of `time`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
