cmccabe commented on pull request #11550: URL: https://github.com/apache/kafka/pull/11550#issuecomment-982901082
Thanks, @mumrah . I took a preliminary look. MetadataVersionManager: this should be a java class in server-common. After all, non-Scala code may need these callbacks. We may also want to use this in the controller. This also would eliminate the need for a separate QuorumFeatures class. I also think that if we have MetadataVersionManager, we should get rid of FinalizedFeatureCache. In general I think the Raft layer should "own" finding what quorum peers have what features. This information comes in the ApiVersionsResponse, and the Raft layer handles those. There should just be an accessor function or something that the controller (or anyone else) can call to find this information. One example of a piece of code that might want this information is, in the long term, we want this to be accessible in the metadata shell as well (if the metadata shell is connected to live controllers) We still need a resolution on getting rid of the min / max feature level thing. This leads to a lot of complexity and confusion in the code so it would be good to just get rid of it. ProduceIdControlManager.java: changes seem unrelated to upgrades -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
