twobeeb opened a new pull request #11575:
URL: https://github.com/apache/kafka/pull/11575


   Currently, the SMT TimestampConverter can convert Timestamp from either 
source String, Long or Date into target String, Long or Date.
   
   The problem is that Long source or target is required to be epoch in 
milliseconds.
   
   In many cases, epoch is represented with different precisions. This leads to 
several Jira tickets :
   
   [KAFKA-12364](https://issues.apache.org/jira/browse/KAFKA-12364): add 
support for date from int32 to timestampconverter
   [KAFKA-10561](https://issues.apache.org/jira/browse/KAFKA-10561): Support 
microseconds precision for Timestamps
   I propose to add a new config to TimestampConverter called "epoch.precision" 
which defaults to "millis" so as to not impact existing code, and allows for 
more precisions : seconds, millis, micros.
   ````json
   "transforms": "TimestampConverter",
   "transforms.TimestampConverter.type": 
"org.apache.kafka.connect.transforms.TimestampConverter$Value",
   "transforms.TimestampConverter.field": "event_date",
   "transforms.TimestampConverter.epoch.precision": "micros",
   "transforms.TimestampConverter.target.type": "Timestamp"
   ````
   Exactly like "format" field which is used as input when the source in String 
and output when the target.type is string, this new field would be used as 
input when the field is Long, and as output when the target.type is "unix"
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to