mimaison commented on pull request #11393: URL: https://github.com/apache/kafka/pull/11393#issuecomment-989911761
> A lot (may be all) of the `create*()` methods could be static. Perhaps that would allow factoring some of the RPC-specific tests into their own classes which would make this class less massive. However, it's not really clear to me that that would result in increased coverage, or make it easier to reason about missing coverage, so I guess I don't really see a benefit to that, but wondered what you thought. Yeah this class is massive and splitting it may be helpful to allow taking a closer look at parts. Considering this PR is already almost +/- 2000 lines, I propose to not do it in this PR though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
