C0urante commented on a change in pull request #10528:
URL: https://github.com/apache/kafka/pull/10528#discussion_r770031575
##########
File path: build.gradle
##########
@@ -1205,6 +1205,7 @@ project(':clients') {
testImplementation libs.bcpkix
testImplementation libs.junitJupiter
+ testImplementation libs.log4j
Review comment:
Jenkins has indeed tested for us and the verdict appears to be that this
dependency is still required. I that the way that we're pulling in the clients
test library prevents transitive dependencies from being included. We might
consider changing `testImplementation
project(':clients').sourceSets.test.output` to just `testImplementation
project(':clients')` but it looks like all non-core projects use that style;
probably best to leave that as-is for now and add the log4j dependency back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
