vvcephei commented on a change in pull request #11582:
URL: https://github.com/apache/kafka/pull/11582#discussion_r771466959
##########
File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java
##########
@@ -29,10 +29,10 @@
*/
public final class QueryResult<R> {
- private final List<String> executionInfo = new LinkedList<>();
private final FailureReason failureReason;
private final String failure;
private final R result;
+ private List<String> executionInfo = new LinkedList<>();
Review comment:
Thanks; that would be another way to do it. I'm not sure if that would
be clearly better or not, though.
It's for getting more details about how the query was actually executed
inside of Streams. Right now, if you request it as part of the query, each
store layer will report what it did and how long it took. For runtime queries,
you wouldn't want to use it, but I wanted to enable debugging if the cases
where query execution seems like it's taking longer than expected. Also, it
could be used for tracing, in which every Nth query is run with the execution
info on.
It's a list of Strings so that each store layer / operation can just add one
"line" of info (like a stack trace), but we don't waste time and memory
actually concatenating them with newlines. We considered adding more structure
(such as having a field for execution time), but kept it as a string so as not
to restrict the kind of "execution information" we might find useful to add in
the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
