ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r776923759
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##########
@@ -296,9 +297,10 @@ private boolean hasPartitionsForAnyTopics(final
List<String> topicNames, final S
}
private Set<String> getStoresOnHost(final Map<String, List<String>>
storeToSourceTopics,
- final Set<TopicPartition> sourceTopicPartitions, final String
topologyName) {
+ final Set<TopicPartition>
sourceTopicPartitions,
+ final String topologyName) {
final InternalTopologyBuilder builder =
topologyMetadata.lookupBuilderForNamedTopology(topologyName);
- final Set<String> sourceTopicNames = builder.sourceTopicNames();
+ final Collection<String> sourceTopicNames =
builder.sourceTopicCollection();
Review comment:
We want the actual ("decorated") topic names. PR #11562 introduced a bug
by using the `sourceTopicNames` with only the raw topic names, this is one of
the main IQ fixes.
100% agree that the names are confusing, I was going to address that in
#11601 but I suppose it makes sense to do that in this PR as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
