[GitHub] [kafka] showuon commented on a change in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

[GitBox]

showuon commented on a change in pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#discussion_r777395790



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##########
@@ -192,14 +214,39 @@
      * @return                          The new values which have been set as 
described in postProcessParsedConfig.
      */
     public static Map<String, Object> 
postProcessReconnectBackoffConfigs(AbstractConfig config,
-                                                    Map<String, Object> 
parsedValues) {
+                                                                         
Map<String, Object> parsedValues) {
         HashMap<String, Object> rval = new HashMap<>();
         if ((!config.originals().containsKey(RECONNECT_BACKOFF_MAX_MS_CONFIG)) 
&&
                 config.originals().containsKey(RECONNECT_BACKOFF_MS_CONFIG)) {
-            log.debug("Disabling exponential reconnect backoff because {} is 
set, but {} is not.",
+            log.info("Disabling exponential reconnect backoff because {} is 
set, but {} is not.",

Review comment:
       Since we log `warn` when exponential `RETRY_BACKOFF_MS` and 
`SOCKET_CONNECTION_SETUP_TIMEOUT_MS` is disabled, I think we should at least 
log `info` here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org