ableegoldman commented on a change in pull request #11600:
URL: https://github.com/apache/kafka/pull/11600#discussion_r781814872
##########
File path: checkstyle/suppressions.xml
##########
@@ -158,7 +158,7 @@
files="(KafkaStreams|KStreamImpl|KTableImpl|InternalTopologyBuilder|StreamsPartitionAssignor|StreamThread).java"/>
<suppress checks="MethodLength"
- files="KTableImpl.java"/>
+ files="(KTableImpl|StreamsPartitionAssignor).java"/>
Review comment:
I would prefer to leave out any nontrivial refactoring such as breaking
up the assignor's ridiculously long `assign` method, though I do agree that it
needs to be broken up (again -- I actually did a pretty hefty refactoring to
clean this method up a while back, I guess it's just gotten out of control
again since then :/ )
Filed a followup ticket to revisit this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
