rondagostino commented on a change in pull request #11616:
URL: https://github.com/apache/kafka/pull/11616#discussion_r784034488
##########
File path: config/kraft/README.md
##########
@@ -35,6 +35,9 @@ Formatting /tmp/kraft-combined-logs
If you are using multiple nodes, then you should run the format command on
each node. Be sure to use the same cluster ID for each one.
+In this example, the `server.properties` file is a `broker,controller`
combined node. If you want to have a separate `broker` and `controller` node,
Review comment:
s/a separate `broker` and `controller` node/separate `broker` and
`controller` nodes/
##########
File path: config/kraft/README.md
##########
@@ -35,6 +35,9 @@ Formatting /tmp/kraft-combined-logs
If you are using multiple nodes, then you should run the format command on
each node. Be sure to use the same cluster ID for each one.
+In this example, the `server.properties` file is a `broker,controller`
combined node. If you want to have a separate `broker` and `controller` node,
+Please find the example properties file
[here](https://github.com/apache/kafka/blob/trunk/config/kraft/broker.properties)
and
[here](https://github.com/apache/kafka/blob/trunk/config/kraft/controller.properties).
Review comment:
s/Please/please/
##########
File path: config/kraft/README.md
##########
@@ -93,7 +96,7 @@
controller.quorum.voters=1...@controller1.example.com:9093,2...@controller2.example.co
Each broker and each controller must set `controller.quorum.voters`. Note
that the node ID supplied in the `controller.quorum.voters` configuration must
match that supplied to the server.
So on controller1, node.id must be set to 1, and so forth. Note that there is
no requirement for controller IDs to start at 0 or 1. However, the easiest and
least confusing way to allocate
-node IDs is probably just to give each server a numeric ID, starting from 0.
+node IDs is probably just to give each server a numeric ID, starting from 0.
Also note that the node ID is global and can not conflict with other node ID no
matter what process role is.
Review comment:
s/Also note that the node ID is global and can not conflict with other
node ID no matter what process role is./Also note that each node ID must be
unique across all the nodes in a particular cluster; no two nodes can have the
same node ID regardless of their `process.roles` values./
##########
File path: config/kraft/broker.properties
##########
@@ -31,22 +31,23 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on. If not configured, the host name
will get from
+# java.net.InetAddress.getCanonicalHostName(), with PLAINTEXT listener name,
and port 9092.
Review comment:
s/the host name will get from/the host name will be equal to the value
of/
##########
File path: config/kraft/broker.properties
##########
@@ -31,22 +31,23 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on. If not configured, the host name
will get from
+# java.net.InetAddress.getCanonicalHostName(), with PLAINTEXT listener name,
and port 9092.
# FORMAT:
# listeners = listener_name://host_name:port
# EXAMPLE:
# listeners = PLAINTEXT://your.host.name:9092
listeners=PLAINTEXT://localhost:9092
+
+# Name of listener used for communication between brokers.
inter.broker.listener.name=PLAINTEXT
-# Hostname and port the broker will advertise to producers and consumers. If
not set,
-# it uses the value for "listeners" if configured. Otherwise, it will use the
value
-# returned from java.net.InetAddress.getCanonicalHostName().
+# Listener name, hostname and port the broker will advertise to producers and
consumers.
+# If not set, it uses the value for "listeners".
advertised.listeners=PLAINTEXT://localhost:9092
-# Listener, host name, and port for the controller to advertise to the
brokers. If
-# this server is a controller, this listener must be configured.
+# A comma-separated list of the names of the listeners used by the controller.
+# This is required if running in KRaft mode.
Review comment:
On a broker node (which this properties file corresponds to) any
listener beyond the first one is ignored. So it would be good to either append
a statement to that effect here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
