C0urante commented on a change in pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#discussion_r785355853
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java
##########
@@ -337,15 +353,29 @@ private void readToLogEnd() {
} else {
log.trace("Behind end offset {} for {}; last-read offset
is {}",
endOffset, topicPartition, lastConsumedOffset);
- poll(Integer.MAX_VALUE);
+ if (topicContainsTransactions) {
+ // The consumer won't return from its poll method if a
transaction is aborted, even though
+ // its position will advance. So, we poll for at most
one second, then give ourselves another
+ // chance to check whether we've reached the end of
the topic.
+ poll(1000);
Review comment:
Now that https://github.com/apache/kafka/pull/11046 has been merged and
this PR has been rebased to include it, we can resolve this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
