viktorsomogyi commented on a change in pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#discussion_r788006560
##########
File path: bin/connect-distributed.sh
##########
@@ -23,13 +23,16 @@ fi
base_dir=$(dirname $0)
if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
+ echo "DEPRECATED: using log4j 1.x configuration. To use log4j 2.x
configuration, run with: 'export
KAFKA_LOG4J_OPTS=\"-Dlog4j.configurationFile=file:$base_dir/../config/connect-log4j2.properties\"'"
export
KAFKA_LOG4J_OPTS="-Dlog4j.configuration=file:$base_dir/../config/connect-log4j.properties"
Review comment:
Why don't you change this (and all the similar cases) to the log4j2
property? If I get it right then after the upgrade `-Dlog4j.configuration`
won't work anyway so while I see the value of notifying the user, I think we
should just use the log4j2 property outright. Or is there a backward
compatibity, so does `log4j.configuration` work under log4j2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
