[GitHub] [kafka] cadonna commented on a change in pull request #11686: KAFKA-12648: invoke exception handler for MissingSourceTopicException with named topologies

[GitBox]

cadonna commented on a change in pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#discussion_r788668651



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -511,15 +512,21 @@ private RepartitionTopics prepareRepartitionTopics(final 
Cluster metadata) {
             metadata,
             logPrefix
         );
-        final boolean isMissingInputTopics = !repartitionTopics.setup();
+        repartitionTopics.setup();
+        final boolean isMissingInputTopics = 
!repartitionTopics.missingSourceTopicExceptions().isEmpty();
         if (isMissingInputTopics) {
             if (!taskManager.topologyMetadata().hasNamedTopologies()) {
                 throw new MissingSourceTopicException("Missing source 
topics.");
+            } else {
+                for (final StreamsException missingSourceTopicException : 
repartitionTopics.missingSourceTopicExceptions()) {
+                    
nonFatalExceptionsToHandle.add(missingSourceTopicException);
+                }

Review comment:
       nit:
   IntelliJ says that this could be simplified to:
   
   ```suggestion
                   
nonFatalExceptionsToHandle.addAll(repartitionTopics.missingSourceTopicExceptions());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org