sayantanu-dey commented on a change in pull request #11703:
URL: https://github.com/apache/kafka/pull/11703#discussion_r790776516
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##########
@@ -171,42 +169,24 @@ private void registerMetrics() {
@Deprecated
private void initStoreSerde(final ProcessorContext context) {
final String storeName = name();
- final String changelogTopic =
ProcessorContextUtils.changelogFor(context, storeName);
- final String prefix = getPrefix(context.appConfigs(),
context.applicationId());
+ final String changelogTopic =
ProcessorContextUtils.changelogFor(context, storeName, Boolean.FALSE);
Review comment:
Hi, after going through the code I realized that the classes like
CachingWindowStore and InMemoryTimeOrderedKeyValueBuffer always need to create
a new topic whereas the classes MeteredXYZStore have a null checking code flow.
As there are two types of flow. So, I thought to have a bool variable
explicitly to have both flows in the same function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
