vvcephei commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r793198150
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBSessionStore.java
##########
@@ -44,9 +43,12 @@
public void init(final StateStoreContext context, final StateStore root) {
super.init(context, root);
this.stateStoreContext = context;
+
+ this.position = super.getPosition();
Review comment:
I see. While digging through the code, I noticed that it's actually
`RocksDB{Session,Windowed}Store`, which wraps SegmentedBytesStore, which wraps
the actual segments (RocksDBStores).
It turns out that SegmentedBytesStore is where we're tracking the position,
and that's also where we do restoration and checkpointing, so in reality, we
just don't need this logic in `RocksDB{Session,Window}Store` at all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
