showuon commented on a change in pull request #11584: URL: https://github.com/apache/kafka/pull/11584#discussion_r800428095
########## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ########## @@ -1516,4 +1527,20 @@ RebalanceProtocol getProtocol() { boolean poll(Timer timer) { return poll(timer, true); } + + + + final static class TopicPartitionComparator implements Comparator<TopicPartition>, Serializable { Review comment: Good point @ableegoldman ! Actually, there's also another partition comparator in [AbstractStickyAssignor.java](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java#L1021) . We could make them into util class or `TopicPartitions` class if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org