cmccabe commented on a change in pull request #11649:
URL: https://github.com/apache/kafka/pull/11649#discussion_r801149465
##########
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##########
@@ -689,7 +689,7 @@ class ControllerApis(val requestChannel: RequestChannel,
def handleCreatePartitions(request: RequestChannel.Request): Unit = {
val future = createPartitions(request.body[CreatePartitionsRequest].data,
authHelper.authorize(request.context, CREATE, CLUSTER, CLUSTER_NAME),
- names => authHelper.filterByAuthorized(request.context, CREATE, TOPIC,
names)(n => n))
+ names => authHelper.filterByAuthorized(request.context, ALTER, TOPIC,
names)(n => n))
Review comment:
We probably should pull out the CREATE -> ALTER fix since in theory you
could be using KRaft + AclAuthorizer. If you want I can do that now (but it
won't have a unit test, hope that's OK).
(It is tested by AuthorizerIntegrationTest but I wouldn't want to backport
that to 3.{0,1})
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
