[GitHub] [kafka] hachikuji commented on a change in pull request #11603: MINOR: MetadataShell should handle ProducerIdsRecord

[GitBox]

hachikuji commented on a change in pull request #11603:
URL: https://github.com/apache/kafka/pull/11603#discussion_r804172617



##########
File path: shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java
##########
@@ -318,6 +320,16 @@ private void handleCommitImpl(MetadataRecordType type, 
ApiMessage message)
                     node.create(record.key()).setContents(record.value() + "");
                 break;
             }
+            case PRODUCER_IDS_RECORD: {
+                ProducerIdsRecord record = (ProducerIdsRecord) message;
+                DirectoryNode producerIdNode = 
data.root.mkdirs("lastProducerIdBlock");
+                
producerIdNode.create("assignedBrokerId").setContents(record.brokerId() + "");
+                
producerIdNode.create("assignedBrokerEpoch").setContents(record.brokerEpoch() + 
"");
+                producerIdNode.create("blockStart")

Review comment:
       FYI: I opened #11747 to hopefully make the naming a little clearer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org