dengziming commented on a change in pull request #11747:
URL: https://github.com/apache/kafka/pull/11747#discussion_r804572420
##########
File path: metadata/src/main/java/org/apache/kafka/image/ProducerIdsImage.java
##########
@@ -50,7 +50,7 @@ public void write(Consumer<List<ApiMessageAndVersion>> out) {
new ProducerIdsRecord().
setBrokerId(-1).
setBrokerEpoch(-1).
- setProducerIdsEnd(highestSeenProducerId), (short) 0)));
+ setNextProducerId(highestSeenProducerId), (short) 0)));
Review comment:
ditto
##########
File path: metadata/src/main/java/org/apache/kafka/image/ProducerIdsDelta.java
##########
@@ -27,11 +27,11 @@ public ProducerIdsDelta(ProducerIdsImage image) {
this.highestSeenProducerId = image.highestSeenProducerId();
}
- public void setHighestSeenProducerId(long highestSeenProducerId) {
+ public void setNextProducerId(long highestSeenProducerId) {
this.highestSeenProducerId = highestSeenProducerId;
Review comment:
maybe we should also change this field name to nextProducerId?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
