lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r805642565
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##########
@@ -59,29 +60,31 @@
private int capacity;
- public ClientState() {
- this(0);
+ public ClientState(final Map<String, String> clientTags) {
+ this(0, clientTags);
}
- ClientState(final int capacity) {
+ ClientState(final int capacity, final Map<String, String> clientTags) {
Review comment:
Thanks for the feedback. No objections from my side. The reason why I
avoided that was to make sure that client tags are always passed. To emphasise
that it's mandatory parameter when constructing the `ClientState` object.
Please note that we have made `ClientState#clientTags` immutable; so there're
no setters for the client tags.
But if you feel like it's better to default to empty map, happy to change it.
Will wait for your response on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
